sys::socket fixes for haiku #2242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asomers
requested changes
Dec 1, 2023
| @@ -447,7 +447,7 @@ impl UnixAddr { | |||
| cfg_if! { | |||
| if #[cfg(any(linux_android, | |||
| target_os = "fuchsia", | |||
| target_os = "illumos", | |||
| solarish, | |||
There was a problem hiding this comment.
Why this change? It doesn't match the commit message.
src/sys/socket/addr.rs
Outdated
| @@ -2327,7 +2327,10 @@ mod tests { | |||
|
|
|||
| #[test] | |||
| fn from_sockaddr_un_named() { | |||
| #[cfg(not(target_os = "haiku"))] | |||
There was a problem hiding this comment.
This socket never actually gets constructed. The test just exercises sockaddr type conversions. So why special case it for Haiku?
devnexen
force-pushed
the
socket_haiku_fix
branch
from
8803091
to
2bbf7a0
Compare
asomers
reviewed
Dec 2, 2023
|
Because it s better using new cfg and solaris was forgotten here. |
But that's a user-visible change, and you didn't put it in the changelog entry or even in the commit message. |
|
I updated the commit message but did not do the changelog change indeed.. |
devnexen
force-pushed
the
socket_haiku_fix
branch
from
2bbf7a0
to
f941fbd
Compare
asomers
requested changes
Dec 2, 2023
changelog/2242.fixed.md
Outdated
| @@ -0,0 +1,2 @@ | |||
| Fixed UnixAddr::new for haiku, it did not record the `sun_len` value as needed. | |||
| Fixed `sys::socket::addr` for solaris to have the same code path as illumos. | |||
There was a problem hiding this comment.
"to have the same code path as illumos" means nothing to end users. Please explain the impact of your change with them in mind.
devnexen
force-pushed
the
socket_haiku_fix
branch
from
f941fbd
to
de1f8cc
Compare
asomers
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.