sys::memfd additional flags related to the hugetlb filesystem support. #2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
force-pushed
the
memfd_more_flags
branch
from
2b3159c
to
5cee82e
Compare
SteveLauC
reviewed
Dec 6, 2023
|
Ok will be adding for android however, preferably not enabling MFD_HUGETLB for FreeBSD since it is not supported (yet) I added a comment. |
devnexen
force-pushed
the
memfd_more_flags
branch
from
a3c4e83
to
c366102
Compare
SteveLauC
requested changes
Dec 6, 2023
src/sys/memfd.rs
Outdated
| /// See also the hugetlb filesystem in [`memfd_create(2)`]. | ||
| /// | ||
| /// [`memfd_create(2)`]: https://man7.org/linux/man-pages/man2/memfd_create.2.html | ||
| #[cfg(any(target_os = "linux", target_os = "android"))] |
There was a problem hiding this comment.
Suggested change
| #[cfg(any(target_os = "linux", target_os = "android"))] | |
| #[cfg(linux_android)] |
Please use the alias instead
devnexen
force-pushed
the
memfd_more_flags
branch
from
c366102
to
bb1e4de
Compare
SteveLauC
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.