Add _PC_MIN_HOLE_SIZE for use with pathconf #2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asomers
force-pushed
the
_PC_MIN_HOLE_SIZE
branch
from
938366b
to
31c3698
Compare
SteveLauC
requested changes
Apr 1, 2024
| /// be aligned to this same value. A special value of 1 is returned if the | ||
| /// file system does not specify the minimum hole size but still reports | ||
| /// holes. | ||
| MIN_HOLE_SIZE = libc::_PC_MIN_HOLE_SIZE, |
There was a problem hiding this comment.
Seems that this is also supported by macOS, though this constant hasn't been added to libc. Anyway, let's merge this PR first:)
https://keith.github.io/xcode-man-pages/pathconf.2.html#_PC_MIN_HOLE_SIZE
asomers
force-pushed
the
_PC_MIN_HOLE_SIZE
branch
from
31c3698
to
dd46636
Compare
SteveLauC
approved these changes
Apr 2, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
Checklist:
CONTRIBUTING.md