sys::termios: adding ControlFlags::ECHO #2420
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
force-pushed
the
fix_pty_solaris_test
branch
3 times, most recently
from
1fe874f
to
d312f70
Compare
While the test_write_ptty_pair passes, the test_read_ptty_pair fails when filling the master buffer. Thus, we disable canonical and echo modes on the slave.
SteveLauC
reviewed
Jun 1, 2024
There was a problem hiding this comment.
Hi
adding ControlFlags::ECHO
Is this cflag available on Solarish? Document from Oracle does not have it.
the test_read_ptty_pair fails when filling the master buffer.
Would you like to show me the error message shown on Solarish systems and why we need that special setup on them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable echoing on input characters.
while at it with this new flag, fixing pty open_tty_pair test for solarish. While the test_write_ptty_pair passes, the test_read_ptty_pair fails when filling the master buffer.
Thus, we disable canonical and echo modes on the slave.