Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Fanotify APIs from the libc crate into Nix. #2552

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

carlvoller
Copy link

@carlvoller carlvoller commented Dec 1, 2024

What does this PR do

Adds support for nix to receive additional Fanotify information records (such as libc::fanotify_event_info_fid, libc::fanotify_event_info_error and libc::fanotify_event_info_pidfd)
Adds abstractions over the new fanotify structs.
Adds new InitFlags to allow receiving these new information records.

This closes #2551

Checklist:

  • I have read CONTRIBUTING.md
  • I have written necessary tests and rustdoc comments
  • A change log has been added if this PR modifies nix's API

@carlvoller
Copy link
Author

I'm not very sure whats going on with the solaris CI failure, but the test that is failing sys::test_uio::test_writev doesn't look related to the changes I've made.

Some guidance would be really appreciated 👍

@SteveLauC SteveLauC self-requested a review December 1, 2024 11:15
@SteveLauC
Copy link
Member

Hi @psumbera, could you please take a look at the Solaris CI failure? It failed in this line

let written = write_res.expect("couldn't write");

  ---- sys::test_uio::test_writev stdout ----
  thread 'sys::test_uio::test_writev' panicked at test/sys/test_uio.rs:48:29:
  couldn't write: EINVAL

@psumbera
Copy link
Contributor

psumbera commented Dec 1, 2024

Hi @psumbera, could you please take a look at the Solaris CI failure? It failed in this line

let written = write_res.expect("couldn't write");

  ---- sys::test_uio::test_writev stdout ----
  thread 'sys::test_uio::test_writev' panicked at test/sys/test_uio.rs:48:29:
  couldn't write: EINVAL

I have seen this one. Seems that this one can fail randomly.

I will create PR to disable this test for Solaris. Sorry about that!

@SteveLauC
Copy link
Member

Sorry about that!

No need to be sorry:)

I will create PR to disable this test for Solaris

Thanks, I will create an issue for this.

@SteveLauC
Copy link
Member

I'm not very sure whats going on with the solaris CI failure, but the test that is failing sys::test_uio::test_writev doesn't look related to the changes I've made.

This test has been disabled, you can rebase your branch to fix the CI:)

@carlvoller
Copy link
Author

Alright, just rebased 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add libc fanotify information record structs and enums into nix.
3 participants