Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add getpgid call #433

Merged
merged 3 commits into from
Oct 28, 2016
Merged

add getpgid call #433

merged 3 commits into from
Oct 28, 2016

Conversation

kiddkai
Copy link
Contributor

@kiddkai kiddkai commented Oct 5, 2016

Add a getpgid function to nix.

Argument is required, either pass in None or Some(pid_t). It should have the same behavior
as the libc one.

@kiddkai
Copy link
Contributor Author

kiddkai commented Oct 5, 2016

The build failure seem not related to this PR?

@homu
Copy link
Contributor

homu commented Oct 21, 2016

☔ The latest upstream changes (presumably #415) made this pull request unmergeable. Please resolve the merge conflicts.

@posborne
Copy link
Member

Hi @kiddkai, now that CI is stable again, can you rebase on master to kick off the tests again?

@kiddkai
Copy link
Contributor Author

kiddkai commented Oct 27, 2016

no problems, will do that today

@kiddkai
Copy link
Contributor Author

kiddkai commented Oct 28, 2016

Hi @posborne , build passes now! 🔥

@posborne
Copy link
Member

@kiddkai Thanks, I think I'm good with this and will merge. We are on a documentation push now, so if you want to add docs (see #449 for some examples) on the function that would also be greatly appreciated.

@homu r+

@homu
Copy link
Contributor

homu commented Oct 28, 2016

📌 Commit ac51932 has been approved by posborne

@homu
Copy link
Contributor

homu commented Oct 28, 2016

⚡ Test exempted - status

@homu homu merged commit ac51932 into nix-rust:master Oct 28, 2016
homu added a commit that referenced this pull request Oct 28, 2016
add getpgid call

Add a `getpgid` function to nix.

Argument is required, either pass in `None` or `Some(pid_t)`. It should have the same behavior
as the `libc` one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants