Specify Rust minimum version requirements #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! There's an RFC issue to figure out the policy: nix-rust/rfcs#4 @homu r+ |
|
📌 Commit 56a56dd has been approved by |
homu
added a commit
that referenced
this pull request
Feb 24, 2017
Specify Rust minimum version requirements I think this is important for 2 reasons: 1) Users know if they can use this library 2) Developers know what Rust features they can use in merge requests What this doesn't do is establish any kind of policy for raising the Rust requirements, which is something worth addressing in the near-future.
Closed
|
☀️ Test successful - status |
|
If bitflags 0.7 does not run on rust 1.7 (see all our 1.7 builds breaking in the CI). >= 1.7 is certainly wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is important for 2 reasons:
What this doesn't do is establish any kind of policy for raising the Rust requirements, which is something worth addressing in the near-future.