Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use libc types for sched and syscall FFI #747

Merged
merged 2 commits into from
Aug 28, 2017
Merged

Use libc types for sched and syscall FFI #747

merged 2 commits into from
Aug 28, 2017

Conversation

Susurrus
Copy link
Contributor

No description provided.

@Susurrus Susurrus mentioned this pull request Aug 26, 2017
Closed
8 tasks
@Susurrus Susurrus changed the title Use libc types for sched FFI Use libc types for sched and syscall FFI Aug 27, 2017
@Susurrus
Copy link
Contributor Author

This also includes removing the src/sys/syscall.rs module completely. This may be controversial, but a) the types were already all exposed by libc and b) the two syscalls exposed here already have safe wrapper functions exposed in nix.

@Susurrus
Copy link
Contributor Author

Blocking on rust-lang/libc#743.

@Susurrus
Remove syscall module.
d322aa9 
This module merely contained FFI declarations, and only enough to
implement memfd_create() and pivot_root() wrapper functions in
nix. Since these declarations are redundant with equivalent FFI
declarations in libc, we'll remove them here. In the future, any
syscall-related wrapper function will be implemented directly and
utilize libc for FFI declarations as we cannot generically expose
a type-safe `syscall()` because of its variadic argument list.
@Susurrus
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Aug 28, 2017
@bors
Merge #747
202f30e 
747: Use libc types for sched and syscall FFI r=Susurrus a=Susurrus
@bors
Copy link
Contributor

bors bot commented Aug 28, 2017

Build succeeded

@bors bors bot merged commit d322aa9 into nix-rust:master Aug 28, 2017
@Susurrus Susurrus deleted the sched_ffi branch August 28, 2017 13:19
@Susurrus Susurrus mentioned this pull request Nov 5, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Susurrus