Add more accessors for AioCb #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asomers
force-pushed
the
aio_accessors
branch
from
4cf2370
to
8a17a5a
Compare
Susurrus
suggested changes
Oct 3, 2017
src/sys/aio.rs
Outdated
|
|
||
| /// Returns the desired length of the aio operation in bytes | ||
| /// | ||
| /// If the operation has completed, this does *not* return the completed |
There was a problem hiding this comment.
Can we embed this into the type system somehow?
There was a problem hiding this comment.
No, but I could probably word it better.
test/sys/test_aio.rs
Outdated
| assert_eq!(99, sev.sigev_value.sival_ptr as i64); | ||
| } | ||
|
|
||
|
|
|
I'm going to consider @Susurrus's statement as a conditional approval. I fixed the newline and updated the description of bors r+ susurrus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.