unistd: add execveat() on Linux and Android #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucab
force-pushed
the
ups/execveat
branch
3 times, most recently
from
c5feda5
to
4741e4f
Compare
|
I had to constrain Linux tests to x86 and amd64 only, as travis was failing with |
|
Please s/Linus/Linux in the commit message. |
This adds execveat() to `nix::unistd`. It uses the execveat(2) Linux kernel syscall, which is available since 3.19. This is a Linux-specific extension which is not covered by POSIX and does not have any userland libc wrapper. Ref: http://man7.org/linux/man-pages/man2/execveat.2.html
|
Woops for the typo. I rebased to fix that and to resolve a conflict on the changelog, PTAL. No, I didn't explicitly test this on Android as I don't have at hand an environment for that. |
|
I don't have an Android test environment either. But it looks correct and Android is only Tier 2, so it's ok to merge. |
|
Ack. May I then get a review and merge? Or is there anything else I can do here? |
bors bot
added a commit
that referenced
this pull request
Nov 21, 2017
800: unistd: add execveat() on Linux and Android r=Susurrus a=lucab This adds execveat() to `nix::unistd`. It uses the execveat(2) Linux kernel syscall, which is available since 3.19. This is a Linux-specific extension which is not covered by POSIX and does not have any userland libc wrapper. Ref: http://man7.org/linux/man-pages/man2/execveat.2.html
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds execveat() to
nix::unistd. It uses the execveat(2) Linuxkernel syscall, which is available since 3.19.
This is a Linux-specific extension which is not covered by POSIX and
does not have any userland libc wrapper.
Ref: http://man7.org/linux/man-pages/man2/execveat.2.html