Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fd ist now RawFd (rustup) #92

Merged
merged 2 commits into from
Apr 7, 2015
Merged

Fd ist now RawFd (rustup) #92

merged 2 commits into from
Apr 7, 2015

Conversation

fhartwig
Copy link
Contributor

@fhartwig fhartwig commented Apr 3, 2015

No description provided.

@fhartwig
Copy link
Contributor Author

fhartwig commented Apr 3, 2015

Tests pass for me, travis failure seems to be unrelated to the changes.

@fhartwig
Copy link
Contributor Author

fhartwig commented Apr 3, 2015

I've now pushed the changes required for the next nightly to this branch as well.

@fhartwig
Copy link
Contributor Author

fhartwig commented Apr 3, 2015

Meh, missed the linux-specific bits again. Sorry, fixing it now.

@Gekkio
Copy link

Gekkio commented Apr 3, 2015

For some reason unknown to me, Clone isn't implemented for statically sized arrays larger than 32 elements, so you can't derive Clone for UtsName. A manual implementation works (fixed-size arrays still have a Copy implementation...?):

impl Clone for UtsName {
    fn clone(&self) -> UtsName {
        UtsName {
            sysname: self.sysname,
            nodename: self.nodename,
            release: self.release,
            version: self.version,
            machine: self.machine,
            domainname: self.domainname
        }
    }
}

With your changes and the above UtsName fix I can compile nix-rust on Ubuntu 64-bit successfully :)

@CraZySacX
Copy link

You can change the clone implementation to

impl Clone for UtsName { fn clone(&self) -> UtsName { *self } }

Per the comment in this issue rust-lang/rust#23860

@fhartwig
Copy link
Contributor Author

fhartwig commented Apr 3, 2015

@CraZySacX @Gekkio Sorry for the breakage, I'm abusing travis as my compiler, since I'm not near a Linux machine. Thanks for your help, should be ok now.

@carllerche carllerche merged commit e5ae756 into nix-rust:master Apr 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants