Add a truncate(2) wrapper #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asomers
reviewed
Oct 17, 2018
| } | ||
| })); | ||
|
|
||
| Errno::result(res).map(drop) |
There was a problem hiding this comment.
I prefer map(|| ()) for stylistic reasons. drop, in this context, is basically being called for its side effect of returning nothing.
There was a problem hiding this comment.
I'm not exactly sure what you'd like to see here, but given that this is a copy/paste from the many, many other functions that follow this style, I think keeping this for consistency is good.
This also adds a test for truncate (obviously) but, while doing so, also adds a test for the already-existing ftruncate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds a test for truncate (obviously) but, while doing so, also
adds a test for the already-existing ftruncate.