Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor capture of arguments #218

Merged
merged 3 commits into from
Oct 22, 2018
Merged

Refactor capture of arguments #218

merged 3 commits into from
Oct 22, 2018

Commits on Oct 6, 2018

  1. Simplify dots passing

    @lionel-
    lionel- committed Oct 6, 2018
    Configuration menu
    Copy the full SHA
    aa73503 View commit details
    Browse the repository at this point in the history

  2. Use as_string() rather than expr_text() 

    The latter is not appropriate here because it's a multi-line deparser
for arbitrary expressions. Symbols should be cast to strings with
`as.character()` or `as_string()`.
    @lionel-
    lionel- committed Oct 6, 2018
    Configuration menu
    Copy the full SHA
    e7b2b88 View commit details
    Browse the repository at this point in the history

  3. Use ensyms() rather than quos() to capture variables 

    The latter is problematic because it allows arbitrary expressions.
These variables are forwarded to select(), so potential expressions
are `starts_with()`, `one_of()`, etc.  The naniar code generally
assumes that only symbols are passed in dots. `ensyms()` is a way of
ensuring the input types.
    @lionel-
    lionel- committed Oct 6, 2018
    Configuration menu
    Copy the full SHA
    3e0552b View commit details
    Browse the repository at this point in the history