Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented predicateMap #36

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

mmopitz
Copy link
Contributor

@mmopitz mmopitz commented May 20, 2019

Refs #31

Implementation Note:
I basically copied the logic of objectMap to implement predicateMap.

@nkons
Copy link
Owner

nkons commented Jun 1, 2019

Hi,

The change is not obvious because the whole file appears to have been changed. Could you please commit in a way that clearly shows changes in the files Parser.java and PredicateObjectMap.java?

Thank you for your contributions.

Best,
Nikolaos

@mmopitz
Copy link
Contributor Author

mmopitz commented Jun 5, 2019

The change is not obvious because the whole file appears to have been changed. Could you please commit in a way that clearly shows changes in the files Parser.java and PredicateObjectMap.java?

Yes you are absolutely right.
The issue was that there seem to be two different types of line separators in the project. Parser.java and PredicateObjectMap.java use CRLF while the rest of the files seem to use LF. I fiddled around a bit and setting git config core.autocrlf false finally did the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants