Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed node imports incompatibility #286

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

Akkuma
Copy link
Contributor

@Akkuma Akkuma commented Apr 21, 2024

Node has reserved # for imports

Entries in the "imports" field must always start with # to ensure they are disambiguated from external package specifiers.

This swaps it to $. I tested it by modifying my node_modules install of vinxi and my dev server worked again resolving #249.

Copy link

codesandbox bot commented Apr 21, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Apr 21, 2024

🦋 Changeset detected

Latest commit: 15c62e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@vinxi/react-server Patch
vinxi Patch
example-react-server Patch
@vinxi/router Patch
react-rsc-spa Patch
react-rsc-ssr Patch
example-react-spa-basic Patch
react-spa-mdx Patch
react-spa-tanstack-router-app Patch
example-react-spa-tanstack-router-app Patch
react-ssr-basic-cloudflare Patch
react-ssr-basic Patch
react-ssr-tanstack-router-app Patch
react-ssr-wouter Patch
solid-spa-basic Patch
solid-ssr-basic Patch
example-ssr-solid-router Patch
example-vanilla-empty Patch
example-vanilla-partyroom Patch
example-vanilla-server Patch
example-vanilla-spa Patch
example-vanilla-stack Patch
example-vanilla-trpc Patch
test-multi-spa Patch
test-react-rsc Patch
test-react-srv-fn Patch
react-ssr-test-fs Patch
test-react-to-web-request Patch
test-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 21, 2024

@Akkuma is attempting to deploy a commit to the Nikhil Saraf's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Akkuma Akkuma changed the title Fixed node imports incompatibility Fixed node imports incompatibility #249 Apr 21, 2024
@Akkuma Akkuma changed the title Fixed node imports incompatibility #249 Fixed node imports incompatibility Apr 21, 2024
@XiNiHa
Copy link
Contributor

XiNiHa commented May 22, 2024

@nksaraf Can we have this reviewed and merged? Utilizing package.json#imports is one of the best ways to use different kinds of modules per condition and Vinxi not supporting it is impacting our adaption of Vinxi/SolidStart.

@nksaraf nksaraf merged commit 02eb648 into nksaraf:main Jun 17, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants