Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vinxi): remove js assets from router targeting server with type http #370

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

SeanCassiere
Copy link
Contributor

@SeanCassiere SeanCassiere commented Sep 7, 2024

Removes the js bundles from the "public/assets" folder for routers that have

  • type = 'http'
  • target = 'server'

Fixes #363

Copy link

codesandbox bot commented Sep 7, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Sep 7, 2024

🦋 Changeset detected

Latest commit: b16e4f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
vinxi Patch
@vinxi/router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 7, 2024

@SeanCassiere is attempting to deploy a commit to the Nikhil Saraf's projects Team on Vercel.

A member of the Team first needs to authorize it.

@SeanCassiere SeanCassiere marked this pull request as ready for review September 7, 2024 07:11
…ers with a type of 'http' and targetting 'server'
@SeanCassiere SeanCassiere changed the title fix: attempt at fixing #363 fix(vinxi): attempt at fixing #363 Sep 7, 2024
Copy link

pkg-pr-new bot commented Sep 7, 2024

Open in Stackblitz

@vinxi/deno-doc

pnpm add https://pkg.pr.new/@vinxi/deno-doc@370

vinxi

pnpm add https://pkg.pr.new/vinxi@370

@vinxi/plugin-directives

pnpm add https://pkg.pr.new/@vinxi/plugin-directives@370

@vinxi/doc

pnpm add https://pkg.pr.new/@vinxi/doc@370

@vinxi/plugin-mdx

pnpm add https://pkg.pr.new/@vinxi/plugin-mdx@370

@vinxi/openapi

pnpm add https://pkg.pr.new/@vinxi/openapi@370

@vinxi/react

pnpm add https://pkg.pr.new/@vinxi/react@370

@vinxi/react-server

pnpm add https://pkg.pr.new/@vinxi/react-server@370

@vinxi/router

pnpm add https://pkg.pr.new/@vinxi/router@370

@vinxi/server-components

pnpm add https://pkg.pr.new/@vinxi/server-components@370

@vinxi/solid

pnpm add https://pkg.pr.new/@vinxi/solid@370

@vinxi/server-functions

pnpm add https://pkg.pr.new/@vinxi/server-functions@370

commit: b16e4f3

@SeanCassiere SeanCassiere changed the title fix(vinxi): attempt at fixing #363 fix(vinxi): remove js assets from router targeting server with type http Sep 7, 2024
@nksaraf nksaraf merged commit cd26a8c into nksaraf:main Sep 13, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent js assets from being added into the public assets when targeting server
2 participants