Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(React): Added Icon component and Icons package #349

Merged
merged 12 commits into from
Jan 2, 2025
Merged

Conversation

MrSkippy
Copy link
Contributor

@MrSkippy MrSkippy commented Dec 24, 2024

Contents

Icons package. Work In Progress / To Be Continued

Checklist

  • New features/components and bugfixes are covered by tests No Time
  • Changesets are created
  • Definition of Done is checked

@MrSkippy MrSkippy linked an issue Dec 24, 2024 that may be closed by this pull request
8 tasks
Copy link

vercel bot commented Dec 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lux ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2024 9:43am

Copy link
Contributor

@remypar5 remypar5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ziet er goed uit. Heb alleen kleine aanmerkingen

packages/components-react/src/icon/Icon.tsx Outdated Show resolved Hide resolved
packages/components-react/src/icon/Icon.tsx Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@remypar5 remypar5 merged commit 3200913 into main Jan 2, 2025
12 checks passed
@remypar5 remypar5 deleted the 236-icons branch January 2, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icons
2 participants