feat: add none option to loading of tokens #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YvetteNikolov
commented
Mar 26, 2024
YvetteNikolov
commented
- Adds a "None" option to the "Load tokens from: " option setting
- Choosing "None" skips the enqueuing of the tokens css
|
Closes #57 |
YvetteNikolov
commented
Mar 26, 2024
| @@ -99,7 +99,7 @@ public function enqueue_block_assets() { | |||
| } | |||
|
|
|||
| $ncb_theme = esc_attr( get_option( 'ncb_municipality', 'denhaag' ) ); | |||
| if ( ! empty( $ncb_theme ) && Plugin::has_resource( NCB_ABSPATH . NCB_ASSETS_DIR . "client/tokens/ncb-$ncb_theme-tokens.css" ) ) { | |||
| if ( ! empty( $ncb_theme ) && 'none' !== $ncb_theme && Plugin::has_resource( NCB_ABSPATH . NCB_ASSETS_DIR . "client/tokens/ncb-$ncb_theme-tokens.css" ) ) { | |||
There was a problem hiding this comment.
Deze extra check is eigenlijk niet nodig aangezien client/tokens/ncb-none-tokens.css niet bestaat, maar dit maakt het wel extra verbose.
Hoor het wel of je deze erin wilt houden.
There was a problem hiding this comment.
@YvetteNikolov door https://github.com/nl-design-system/nlds-community-blocks/pull/59/files#diff-04431c910a832ed347d95798fed2aff245c7c2a55216b2cec706ffae3939cc1bR262 is deze PR redundant ;-)
Ik heb de default-value naar '' gezet. Hierdoor komt hij niet door de bestaande check heen en slaat hij ook geen waarde op in de DB. https://github.com/nl-design-system/nlds-community-blocks/pull/59/files#diff-dcb10c72c98add895cdf03a53eb725d995c84960e501d915d3cfc5fc36297b8fR99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.