Large VW tokens naar apart css bestand schrijven #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set underline tokens to none change utrecht-heading tokens add nora-page-layout tokens add nora-page-section tokens
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #772 +/- ##
=======================================
Coverage 89.41% 89.41%
=======================================
Files 13 13
Lines 1049 1049
Branches 91 147 +56
=======================================
Hits 938 938
+ Misses 111 110 -1
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
large-vwin hun path hebben worden nu als variabelen naartheme-large-vw.cssenvariables-large-vw.cssgeschreven.large-vwaanduidinglarge-vwaanduiding intheme.cssenvariables.cssDit maakt het mogelijk om tokens die specifiek bedoeld zijn voor een grotere viewport width te gebruiken in combinatie met een media-query, bijvoorbeeld als volgt:
@import '@nl-design-system-community/nora-design-tokens/dist/theme-large-vw.css' (min-width: 992px);