Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export ligands when constructing multi-ligand quantum dots #115

Closed
BvB93 opened this issue May 22, 2020 · 0 comments · Fixed by #126
Closed

Export ligands when constructing multi-ligand quantum dots #115

BvB93 opened this issue May 22, 2020 · 0 comments · Fixed by #126
Assignees
@BvB93
Labels
bug Something isn't working
Milestone
CAT 0.9.4

Comments

@BvB93
Copy link
Member

BvB93 commented May 22, 2020

Currently only the quantum dots themselves are exported (conforming user-provided settings) when constructing multi-ligand quantum dots.
Notably, this does not include the ligands.
@BvB93 BvB93 added the bug Something isn't working label May 22, 2020
@BvB93 BvB93 self-assigned this May 22, 2020
@BvB93 BvB93 mentioned this issue Jun 11, 2020
Merged
2 tasks
@BvB93 BvB93 linked a pull request Jun 11, 2020 that will close this issue
CAT 0.9.4 #126
Merged
2 tasks
BvB93 pushed a commit that referenced this issue Jun 11, 2020
Fixed #115
3736613
BvB93 added a commit that referenced this issue Jun 11, 2020
@BvB93
CAT 0.9.4 (#126)
c3b2993 
* Fixed an issue where certain `AMSJob`s would have duplicate keys.
* Fixed an issue where certain ligands weren't exported when constructing multi-ligand quantum dots (see #115).
@BvB93 BvB93 added this to the CAT 0.9.4 milestone Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BvB93 BvB93

Labels
bug Something isn't working
Projects
None yet
Milestone
CAT 0.9.4
Development

Successfully merging a pull request may close this issue.

CAT 0.9.4 nlesc-nano/CAT
1 participant
@BvB93