Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data-CAT 0.3.0 #25

Merged
merged 22 commits into from
Jun 19, 2020
Merged

Data-CAT 0.3.0 #25

merged 22 commits into from
Jun 19, 2020

Conversation

BvB93
Copy link
Member

@BvB93 BvB93 commented Jun 16, 2020

  • Overhauled the .pdb storage system.
  • Introduced the PDBContainer class.
  • Renamed dataCAT.database_functions to dataCAT.functions.

@BvB93 BvB93 added enhancement New feature or request Work in Progress Work in progress labels Jun 16, 2020
@BvB93 BvB93 self-assigned this Jun 16, 2020
BvB93 pushed a commit to nlesc-nano/CAT that referenced this pull request Jun 16, 2020
@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #25 into master will increase coverage by 1.77%.
The diff coverage is 90.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   85.02%   86.79%   +1.77%     
==========================================
  Files           7        8       +1     
  Lines         641      939     +298     
  Branches       92      143      +51     
==========================================
+ Hits          545      815     +270     
- Misses         74       92      +18     
- Partials       22       32      +10     
Impacted Files Coverage Δ
dataCAT/functions.py 81.73% <71.15%> (ø)
dataCAT/database.py 76.60% <80.00%> (-0.50%) ⬇️
dataCAT/pdb_array.py 95.11% <95.11%> (ø)
dataCAT/__init__.py 100.00% <100.00%> (ø)
dataCAT/__version__.py 100.00% <100.00%> (ø)
dataCAT/create_database.py 96.74% <100.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e967c1c...42a3b1e. Read the comment docs.

BvB93 pushed a commit to nlesc-nano/CAT that referenced this pull request Jun 18, 2020
@BvB93 BvB93 removed the Work in Progress Work in progress label Jun 19, 2020
@BvB93 BvB93 marked this pull request as ready for review June 19, 2020 13:14
BvB93 pushed a commit to nlesc-nano/CAT that referenced this pull request Jun 19, 2020
@BvB93
Copy link
Member Author

BvB93 commented Jun 19, 2020

Note to self:
Certain doctests (e.g. PDBContaoner.__eq__()) seem to be failing without any obvious reason.
Moving aforementioned tests to a tests/ fixed the issue.

@BvB93 BvB93 merged commit b0ce7c5 into master Jun 19, 2020
BvB93 added a commit to nlesc-nano/CAT that referenced this pull request Jun 19, 2020
*  Update the documentation for nlesc-nano/data-CAT#25.
BvB93 pushed a commit to nlesc-nano/CAT that referenced this pull request Jun 19, 2020
BvB93 pushed a commit to nlesc-nano/CAT that referenced this pull request Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant