Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new features to the ligand dissociation module #1

Closed
BvB93 opened this issue Apr 3, 2019 · 7 comments
Closed

Add new features to the ligand dissociation module #1

BvB93 opened this issue Apr 3, 2019 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@BvB93
Copy link
Member

BvB93 commented Apr 3, 2019

XYn dissociation
X: Core atom (e.g. Cd)
Y: Ligand (e.g. acetate)
n: The number of ligands (e.g. 2)

  • Implement the construction of XYn when n != 2.
  • Allow X to be a molecule and not just an atom.
  • Use radial distribution functions to determine whether or not X is located on the surface.
  • Provide users the ability to perform a XYn search based on core atoms (X) rather than ligands (Y).
  • Ligand Dissociation Energies Workflow with restart feature from Noodles.
  • Provide users the capability to perform a dry run.
@BvB93 BvB93 self-assigned this Apr 3, 2019
@BvB93
Copy link
Member Author

BvB93 commented Apr 12, 2019

Addition:

  • Provide users the ability to perform a XYn search based on core atoms (X) rather than ligands (Y)

@BvB93
Copy link
Member Author

BvB93 commented Apr 12, 2019

Note to self: Clean up the code
See nlesc-nano/CAT#35.

@BvB93
Copy link
Member Author

BvB93 commented Apr 12, 2019

Implemented: Provide users the ability to perform a XYn search based on core atoms (X) rather than ligands (Y)

BvB93 referenced this issue in nlesc-nano/CAT Apr 12, 2019
Implemented the option to perform a XYn search based on core atoms (X) rather than ligands (Y)
@BvB93
Copy link
Member Author

BvB93 commented Jun 25, 2019

n = 0 is now an accepted argument for constructing XYn

@BvB93 BvB93 transferred this issue from nlesc-nano/CAT Jun 27, 2019
BvB93 pushed a commit that referenced this issue Jul 15, 2019
@BvB93 BvB93 added the enhancement New feature or request label Jul 15, 2019
@BvB93
Copy link
Member Author

BvB93 commented Jul 15, 2019

Implemented in 79fa320:

  • Implement the construction of XYn when n != 2
  • Allow X to be a molecule and not just an atom

BvB93 pushed a commit that referenced this issue Jul 16, 2019
The option.qd.dissociate.core_core_dist parameter (https://cat.readthedocs.io/en/latest/5_bde.html#arguments) can now be guessed based on its radial distribution function.

See #1.
@BvB93
Copy link
Member Author

BvB93 commented Jul 16, 2019

Implemented in b985631:

  • Use radial distribution functions to determine whether or not X is located on the surface.

@BvB93
Copy link
Member Author

BvB93 commented Jul 17, 2019

Results from previous jobs are now automatically loaded if a job quits unexpectedly.
See Rerun prevention

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant