Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a build script for vector_add #123

Merged
merged 6 commits into from
Mar 7, 2022
Merged

Add a build script for vector_add #123

merged 6 commits into from
Mar 7, 2022

Conversation

abelsiqueira
Copy link
Member

@abelsiqueira abelsiqueira commented Mar 4, 2022

Description

Add a build script for the tests folder and the vector_add test/example.

Related issues:

Instructions to review the pull request

  • Check that CHANGELOG.md has been updated if necessary

Clone and verify

cd $(mktemp -d --tmpdir cudawrappers-XXXXXX)
git clone https://github.com/nlesc-recruit/cudawrappers .
git checkout <this-branch>
cmake -S . -B build
make -C build
# prepend the following with `srun -N 1 -C TitanX --gres=gpu:1` on DAS
make -C build test
make -C build format # Nothing should change
make -C build lint # linting is broken until we fix the issues (see #92)

@abelsiqueira
Copy link
Member Author

I have started a discussion on #116 which is blocking this.

@abelsiqueira abelsiqueira changed the title [WIP] Working on a build script for vector_add Add a build script for vector_add Mar 4, 2022
@abelsiqueira abelsiqueira marked this pull request as ready for review March 4, 2022 16:14
tests/CMakeLists.txt Outdated Show resolved Hide resolved
README.dev.md Outdated Show resolved Hide resolved
README.dev.md Show resolved Hide resolved
Co-authored-by: Faruk D. <144492+fdiblen@users.noreply.github.com>
Copy link
Member

@fdiblen fdiblen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I made a few suggestions.

Copy link
Member

@fdiblen fdiblen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abelsiqueira 🍪

@abelsiqueira
Copy link
Member Author

Thanks for the review 🥦

@abelsiqueira abelsiqueira merged commit 8145a61 into main Mar 7, 2022
@abelsiqueira abelsiqueira deleted the 116-vector-add branch March 7, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants