Fix typo in inline_local_includes macro #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loostrum
approved these changes
May 21, 2024
loostrum
added a commit
that referenced
this pull request
Jun 18, 2024
* Added cu::Function::occupancyMaxActiveBlocksPerMultiprocessor() * Let target_embed_source inline local header files (#263) * Fix working directory for linking source into object file (#264) * Update readthedocs configuration (#265) * Fix target_embed_source when input file is a relative path (#266) * Removed deprecated cu::Context::setSharedMemConfig (#267) * Extend api (#268) * Add Device::getUUID * Add initial nvml wrapper * Fix target_embed_source (#269) * Fix target embed source paths (#270) * Fix path given to ld in target_embed_source * Fix missing arg in string replace * Fix CI (#271) * Add runtime subpackage * Fix symbols for test_nvrtc * [pre-commit.ci] pre-commit autoupdate (#259) * Update clang-format: v17.0.6 → v18.1.4 * Replace cmakelang with clang-format and cmake-format * Add nvrtc::findIncludePath (#272) * Make nvrtc::findIncludePath inline (#273) * Fix string replacements (#275) * Fix inline_local_includes (#276) * Make sure to select the correct INCLUDE_PATH (#277) * Fix typo (#278) * [pre-commit.ci] pre-commit autoupdate (#274) updates: - [github.com/pre-commit/mirrors-clang-format: v18.1.4 → v18.1.5](pre-commit/mirrors-clang-format@v18.1.4...v18.1.5) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Add inlined headers as dependencies in target_embed_source (#279) * Add inlined headers as dependencies in target_embed_source This ensure that the embedded sources are rebuild when a header is changed * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update cmake/cudawrappers-helper.cmake Co-authored-by: Bram Veenboer <veenboer@astron.nl> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Bram Veenboer <veenboer@astron.nl> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add HIP version of occupancyMaxActiveBlocksPerMultiprocessor * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: John Romein <romein@astron.nl> Co-authored-by: john-romein <39552858+john-romein@users.noreply.github.com> Co-authored-by: Bram Veenboer <veenboer@astron.nl> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
csbnw
added a commit
that referenced
this pull request
Jul 9, 2024
* Added cu::Function::occupancyMaxActiveBlocksPerMultiprocessor() * Let target_embed_source inline local header files (#263) * Fix working directory for linking source into object file (#264) * Update readthedocs configuration (#265) * Fix target_embed_source when input file is a relative path (#266) * Removed deprecated cu::Context::setSharedMemConfig (#267) * Extend api (#268) * Add Device::getUUID * Add initial nvml wrapper * Fix target_embed_source (#269) * Fix target embed source paths (#270) * Fix path given to ld in target_embed_source * Fix missing arg in string replace * Fix CI (#271) * Add runtime subpackage * Fix symbols for test_nvrtc * [pre-commit.ci] pre-commit autoupdate (#259) * Update clang-format: v17.0.6 → v18.1.4 * Replace cmakelang with clang-format and cmake-format * Add nvrtc::findIncludePath (#272) * Make nvrtc::findIncludePath inline (#273) * Fix string replacements (#275) * Fix inline_local_includes (#276) * Make sure to select the correct INCLUDE_PATH (#277) * Fix typo (#278) * [pre-commit.ci] pre-commit autoupdate (#274) updates: - [github.com/pre-commit/mirrors-clang-format: v18.1.4 → v18.1.5](pre-commit/mirrors-clang-format@v18.1.4...v18.1.5) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Add inlined headers as dependencies in target_embed_source (#279) * Add inlined headers as dependencies in target_embed_source This ensure that the embedded sources are rebuild when a header is changed * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update cmake/cudawrappers-helper.cmake Co-authored-by: Bram Veenboer <veenboer@astron.nl> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Bram Veenboer <veenboer@astron.nl> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add HIP version of occupancyMaxActiveBlocksPerMultiprocessor * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: John Romein <romein@astron.nl> Co-authored-by: john-romein <39552858+john-romein@users.noreply.github.com> Co-authored-by: Bram Veenboer <veenboer@astron.nl> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
contained a typo, causing the
inline_local_includesmacro to fail.Related issues: