Add memset #300
Merged
Add memset #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csbnw
commented
Aug 14, 2024
csbnw
commented
Aug 14, 2024
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #299, adding
cu::DeviceMemory::memsetandcu::Stream::memsetAsyncmethods. Thetest_cuhas been extended to also cover the new functionality.Additionally, the existing
::zeromethods now call the appropriatememset(Async)method, instead of repeating the CUDA driver API call.To implement the tests, some minor cleanup to pre-existing tests was done. These changes are so insignificant that I don't think they warrant their own PR.
Related issues:
Instructions to review the pull request