Skip to content

Commit

Permalink
Disable regression test for #3070 on GCC <8.4
Browse files Browse the repository at this point in the history
  • Loading branch information
falbrechtskirchinger committed Apr 22, 2022
1 parent a944306 commit 7cd3120
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions test/src/unit-regression2.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ using ordered_json = nlohmann::ordered_json;
#endif

#if JSON_HAS_EXPERIMENTAL_FILESYSTEM
// JSON_HAS_CPP_17 (magic keyword; do not remove)
#include <experimental/filesystem>
namespace nlohmann::detail
{
Expand All @@ -61,7 +62,6 @@ namespace std_fs = std::filesystem;
} // namespace nlohmann::detail
#endif


#ifdef JSON_HAS_CPP_20
#include <span>
#endif
Expand Down Expand Up @@ -793,8 +793,8 @@ TEST_CASE("regression tests 2")
const auto j_path = j.get<nlohmann::detail::std_fs::path>();
CHECK(j_path == text_path);

#ifndef _MSC_VER
// works everywhere but on MSVC
#if !defined(_MSC_VER) && !(defined(__GNUC__) && __GNUC__ == 8 && __GNUC_MINOR__ < 4)
// works everywhere but on MSVC and GCC <8.4
CHECK_THROWS_WITH_AS(nlohmann::detail::std_fs::path(json(1)), "[json.exception.type_error.302] type must be string, but is number", json::type_error);
#endif
}
Expand Down

0 comments on commit 7cd3120

Please sign in to comment.