Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add assertions #168

Closed
nlohmann opened this issue Jan 1, 2016 · 3 comments
Closed

Add assertions #168

nlohmann opened this issue Jan 1, 2016 · 3 comments
Assignees
@nlohmann
Labels
kind: enhancement/improvement
Milestone
Release 1.1.0

Comments

@nlohmann
Copy link
Owner

nlohmann commented Jan 1, 2016

As proposed on Reddit, the code should be enriched with assertions to document and check the invariants of the functions.
@nlohmann nlohmann self-assigned this Jan 3, 2016
nlohmann added a commit that referenced this issue Jan 3, 2016
@nlohmann
added assertions (#168)
4a452f1
@nlohmann
Copy link
Owner Author

nlohmann commented Jan 3, 2016

I added assertions for pointer access and iterator dereferencing.

@nlohmann
Copy link
Owner Author

nlohmann commented Jan 3, 2016

Todo:

  • Add a note to file README.md explaining how assertions can be switched off.

@nlohmann nlohmann added this to the Release 1.0.1 milestone Jan 3, 2016
nlohmann added a commit that referenced this issue Jan 13, 2016
@nlohmann
added note on assertions (#168)
c0bb5a5
@nlohmann
Copy link
Owner Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlohmann nlohmann

Labels
kind: enhancement/improvement
Projects
None yet
Milestone
Release 1.1.0
Development

No branches or pull requests
1 participant
@nlohmann