-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patch_inplace assumes StringType is std::string #4134
Labels
Comments
Seems easy enough to fix. If you care to submit a PR, please add a regression test to |
tomalakgeretkal
added a commit
to tomalakgeretkal/nlohmann-json
that referenced
this issue
Sep 6, 2023
tomalakgeretkal
added a commit
to tomalakgeretkal/nlohmann-json
that referenced
this issue
Sep 8, 2023
tomalakgeretkal
added a commit
to tomalakgeretkal/nlohmann-json
that referenced
this issue
Sep 25, 2023
tomalakgeretkal
added a commit
to tomalakgeretkal/nlohmann-json
that referenced
this issue
Sep 25, 2023
tomalakgeretkal
added a commit
to tomalakgeretkal/nlohmann-json
that referenced
this issue
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
patch_inplace
has several instances ofget<std::string>
, which breaks the build if you're using a custom string.Reproduction steps
Expected vs. actual results
Compilation fails.
Minimal code example
Error messages
Compiler and operating system
Apple clang version 14.0.3 (clang-1403.0.22.14.1), macOS Ventura 13.5.1
Library version
3.11.2
Validation
develop
branch is used.The text was updated successfully, but these errors were encountered: