Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #1058

Merged
merged 2 commits into from
Apr 17, 2018
Merged

Fix typo #1058

merged 2 commits into from
Apr 17, 2018

Conversation

dns13
Copy link
Contributor

@dns13 dns13 commented Apr 17, 2018

Just fixed a typo in the docs.

@nlohmann
Copy link
Owner

You need to change the files in the include and single_include folder, see the Files to Change section in https://github.com/nlohmann/json/blob/develop/.github/CONTRIBUTING.md

@dns13
Copy link
Contributor Author

dns13 commented Apr 17, 2018

Oops, this happens when you don't read everything. Thought single_include will bei autogenerated by ci. Sorry, fixed it.

@coveralls
Copy link

coveralls commented Apr 17, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 65b4d82 on dns13:patch-1 into 46ec2fd on nlohmann:develop.

nlohmann
nlohmann approved these changes Apr 17, 2018
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Apr 17, 2018
@nlohmann nlohmann added this to the Release 3.1.3 milestone Apr 17, 2018
@nlohmann nlohmann merged commit 0ab8fab into nlohmann:develop Apr 17, 2018
@nlohmann
Copy link
Owner

Thanks!

@dns13 dns13 deleted the patch-1 branch April 18, 2018 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
documentation
Projects
None yet
Milestone
Release 3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dns13 @nlohmann @coveralls