Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test (non)equality for alt_string implementation #1130

Merged
merged 4 commits into from
Jun 18, 2018
Merged

test (non)equality for alt_string implementation #1130

merged 4 commits into from
Jun 18, 2018

Conversation

agrianius
Copy link
Contributor

Add a bit more tests for alt_string implementation

@coveralls
Copy link

coveralls commented Jun 13, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling f574d7e on agrianius:develop into e830bc5 on nlohmann:develop.

@agrianius
Copy link
Contributor Author

apt-get install failed
The command "sudo -E apt-get -yq --no-install-suggests --no-install-recommends --force-yes install g++-4.9 valgrind ninja-build" failed and exited with 100 during .

Seems like a network problem. How to relaunch the tests?

@theodelrieu
Copy link
Contributor

Yes it happens sometimes, you can run:

git commit --amend --no-edit && git push --force

@nlohmann
Copy link
Owner

What is the goal of this PR? Improve test coverage?

@agrianius
Copy link
Contributor Author

Yes. I found that some revisions of the library fail this tests (I'm using similar logic in my application).

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Jun 18, 2018
@nlohmann nlohmann added this to the Release 3.1.3 milestone Jun 18, 2018
@nlohmann nlohmann merged commit 1c81e9f into nlohmann:develop Jun 18, 2018
@nlohmann
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants