Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links to cppreference named requirements (formerly concepts) #1144

Merged
merged 2 commits into from Jun 26, 2018
Merged

Fix links to cppreference named requirements (formerly concepts) #1144

merged 2 commits into from Jun 26, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jun 24, 2018

The link in https://github.com/nlohmann/json#stl-like-access is broken.
It points to https://en.cppreference.com/w/cpp/concept/ReversibleContainer.

"Concepts" have been renamed to "named requirements".
This is because P0898R3 Standard Library Concepts has been merged into
C++20: cplusplus/draft#2145.
Cppreference have moved their links accordingly.

This PR also links to HTTPS and not HTTP.

Julius Rakow added 2 commits June 24, 2018 22:34
"Concepts" have been renamed to "named requirements".
This is because P0898R3 Standard Library Concepts has been merged into
C++20.
Cppreference have moved their links accordingly.
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Jun 24, 2018
@nlohmann nlohmann added this to the Release 3.1.3 milestone Jun 24, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 963d06a on jrakow:cppreference-link-fix into 6245772 on nlohmann:develop.

@nlohmann nlohmann merged commit bab5826 into nlohmann:develop Jun 26, 2018
@nlohmann
Copy link
Owner

Thanks!

@ghost ghost deleted the cppreference-link-fix branch June 26, 2018 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants