Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve diagnostic messages #1282

Merged
merged 4 commits into from
Oct 8, 2018
Merged

Improve diagnostic messages #1282

merged 4 commits into from
Oct 8, 2018

Conversation

nlohmann
Copy link
Owner

@nlohmann nlohmann commented Oct 7, 2018

This is a follow-up to #1210.

  • added line and column information where possible
  • improved error messages in case of unescaped control characters
  • added context to error messages

@nlohmann nlohmann mentioned this pull request Oct 7, 2018
4 tasks
@coveralls
Copy link

coveralls commented Oct 7, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 74a3107 on feature/lines_columns into ac38e95 on develop.

@efp
Copy link

efp commented Oct 8, 2018

I did a fresh checkout and it looks good to me.

@nlohmann nlohmann self-assigned this Oct 8, 2018
@nlohmann nlohmann added this to the Release 3.3.1 milestone Oct 8, 2018
@nlohmann nlohmann merged commit e426219 into develop Oct 8, 2018
@nlohmann nlohmann deleted the feature/lines_columns branch October 8, 2018 20:17
nlohmann added a commit that referenced this pull request Oct 17, 2018
This commit is the equivalent of #1282 for CBOR, MessagePack, and UBJSON.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants