Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recommend using explicit from JSON conversions #1363

Merged
merged 1 commit into from
Dec 2, 2018
Merged

recommend using explicit from JSON conversions #1363

merged 1 commit into from
Dec 2, 2018

Conversation

theodelrieu
Copy link
Contributor

@theodelrieu theodelrieu commented Nov 19, 2018 •
edited
Loading

This is the minimum we can do about #958.

Pull request checklist

Read the Contribution Guidelines for detailed information.

  • Changes are described in the pull request, or an existing issue is referenced.
  • The test suite compiles and runs without error.
  • Code coverage is 100%. Test cases can be added by editing the test suite.
  • The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header file single_include/nlohmann/json.hpp. The whole process is described here.

@coveralls
Copy link

coveralls commented Nov 19, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 7b96136 on theodelrieu:doc/implicit_conversions into da81e7b on nlohmann:develop.

@theodelrieu theodelrieu force-pushed the doc/implicit_conversions branch from 86b16a3 to 7b96136 Compare November 20, 2018 13:14
@theodelrieu
Copy link
Contributor Author

@nlohmann Any update on this one?

@nlohmann
Copy link
Owner

nlohmann commented Dec 1, 2018

Sorry, did not find the time. I’ll try to check tomorrow.

nlohmann
nlohmann approved these changes Dec 2, 2018
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Dec 2, 2018
@nlohmann nlohmann added this to the Release 3.4.1 milestone Dec 2, 2018
@nlohmann nlohmann merged commit d53873a into nlohmann:develop Dec 2, 2018
@nlohmann
Copy link
Owner

nlohmann commented Dec 2, 2018

Thanks!

@theodelrieu theodelrieu deleted the doc/implicit_conversions branch December 3, 2018 10:00
@theodelrieu theodelrieu mentioned this pull request Dec 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: ⚡ improvement
Projects
None yet
Milestone
Release 3.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@theodelrieu @coveralls @nlohmann