Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readme: fix typo #1380

Merged
merged 1 commit into from
Dec 2, 2018
Merged

readme: fix typo #1380

merged 1 commit into from
Dec 2, 2018

Conversation

manu-chroma
Copy link
Contributor

@manu-chroma manu-chroma commented Dec 1, 2018 •
edited
Loading

Just correcting a minor typo: agains -> against

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5de184b on manu-chroma:patch-1 into ef90d62 on nlohmann:develop.

nlohmann
nlohmann approved these changes Dec 2, 2018
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Dec 2, 2018
@nlohmann nlohmann added this to the Release 3.4.1 milestone Dec 2, 2018
@nlohmann nlohmann merged commit 7a56f5a into nlohmann:develop Dec 2, 2018
@nlohmann
Copy link
Owner

nlohmann commented Dec 2, 2018

Thanks!

@manu-chroma manu-chroma deleted the patch-1 branch December 2, 2018 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: ⚡ improvement
Projects
None yet
Milestone
Release 3.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@manu-chroma @coveralls @nlohmann