Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double delete on std::bad_alloc exception #14

Merged
merged 1 commit into from
Jan 6, 2015

Conversation

elliotgoodrich
Copy link
Contributor

If the new operator throws in the json::find methods then result.oi_ is
deleted again in the destructor of json::iterator/json::const_iterator,
which is a double delete and undefined behaviour.

If the new operator throws in the json::find methods then result.oi_ is
deleted again in the destructor of json::iterator/json::const_iterator,
which is a double delete and undefined behaviour.
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 0773f40 on elliotgoodrich:master into 4f0afbb on nlohmann:master.

nlohmann added a commit that referenced this pull request Jan 6, 2015
Fix double delete on std::bad_alloc exception
@nlohmann nlohmann merged commit 5f05d02 into nlohmann:master Jan 6, 2015
@nlohmann
Copy link
Owner

nlohmann commented Jan 6, 2015

Thanks!

@cronnosli cronnosli mentioned this pull request Oct 8, 2017
@Hoohya Hoohya mentioned this pull request Jan 2, 2020
GerHobbelt pushed a commit to GerHobbelt/nlohmann-json that referenced this pull request May 7, 2021
925316 pushed a commit to 925316/json that referenced this pull request Sep 26, 2024
keep name spoofing menu button(nlohmann#14)
add smooth self-aim(nlohmann#7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants