Remove C++17 extension warning from clang; #1535

[heavywatal]

This PR is an attempt to fix #1535.

• Switch off nodiscard for clang unless C++17 is detected.
• Detect C++ standard before the switch.

[Describe your pull request here. Please read the text below the line, and make sure you follow the checklist.]

---

Pull request checklist

Read the Contribution Guidelines for detailed information.

• Changes are described in the pull request, or an existing issue is referenced.
• The test suite compiles and runs without error.
• Code coverage is 100%. Test cases can be added by editing the test suite.
• The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header file single_include/nlohmann/json.hpp. The whole process is described here.

Please don't

• The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
• Specifically, I am aware of compilation problems with Microsoft Visual Studio (there even is an issue label for these kind of bugs). I understand that even in 2016, complete C++11 support isn't there yet. But please also understand that I do not want to drop features or uglify the code just to make Microsoft's sub-standard compiler happy. The past has shown that there are ways to express the functionality such that the code compiles with the most recent MSVC - unfortunately, this is not the main objective of the project.
• Please refrain from proposing changes that would break JSON conformance. If you propose a conformant extension of JSON to be supported by the library, please motivate this extension.
• Please do not open pull requests that address multiple issues.

[coveralls]

Coverage remained the same at 100.0% when pulling 5ccdaf6 on heavywatal:fix-1535-nodiscard-clang into d79c168 on nlohmann:develop.

[nlohmann]

Looks good to me.

[nlohmann]

---

🔖 Release item

This issue/PR will be part of the next release of the library. This template helps preparing the release notes.

Type

• ✨ New Feature
• 🐛 Bug Fix
• ⚡️ Improvement
• 🔨 Further Change
• 🔥 Deprecated function

Description

• Fixed a -Wc++17-extensions warning. nodiscard attributes are now only used with Clang when -std=c++17 is used. [Clang] warning: use of the 'nodiscard' attribute is a C++17 extension [-Wc++17-extensions] #1535 Remove C++17 extension warning from clang; #1535 #1551

Contributor entry

• Watal M. Iwasaki fixed a Clang warning.

---

[nlohmann]

Thanks!