Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #1907

Merged
merged 1 commit into from
Jan 19, 2020
Merged

Update README.md #1907

merged 1 commit into from
Jan 19, 2020

Conversation

pauljurczak
Copy link
Contributor

See j[1] = 42; two lines above.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling bc95563 on pauljurczak:patch-1 into 7acf621 on nlohmann:develop.

nlohmann
nlohmann approved these changes Jan 19, 2020
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@nlohmann
Copy link
Owner

Good catch!

@nlohmann nlohmann self-assigned this Jan 19, 2020
@nlohmann nlohmann added this to the Release 3.7.4 milestone Jan 19, 2020
@nlohmann nlohmann merged commit ad383f6 into nlohmann:develop Jan 19, 2020
@nlohmann
Copy link
Owner

🔖 Release item

This issue/PR will be part of the next release of the library. This template helps preparing the release notes.

Type

  • ✨ New Feature
  • 🐛 Bug Fix
  • ⚡️ Improvement
  • 🔨 Further Change
  • 🔥 Deprecated function

Description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: 🔨 further change
Projects
None yet
Milestone
Release 3.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pauljurczak @coveralls @nlohmann