Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify the document about operator== #1984

Merged
merged 1 commit into from
Apr 11, 2020
Merged

Modify the document about operator== #1984

merged 1 commit into from
Apr 11, 2020

Conversation

dota17
Copy link
Contributor

@dota17 dota17 commented Mar 12, 2020

No description provided.

@dota17 dota17 requested a review from nlohmann as a code owner March 12, 2020 11:17
@dota17
Copy link
Contributor Author

dota17 commented Mar 12, 2020

Related issues #1915 #1953

nlohmann
nlohmann requested changes Mar 20, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
include/nlohmann/json.hpp Outdated Show resolved Hide resolved
@nlohmann nlohmann mentioned this pull request Mar 21, 2020
Closed
@dota17 dota17 changed the title Add user self-defined content in README and modify the document about operator== Modify the document about operator== Mar 24, 2020
nlohmann
nlohmann requested changes Mar 24, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@dota17 dota17 closed this Apr 7, 2020
@dota17 dota17 reopened this Apr 7, 2020
nlohmann
nlohmann approved these changes Apr 11, 2020
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Apr 11, 2020
@nlohmann nlohmann added this to the Release 3.7.4 milestone Apr 11, 2020
@nlohmann
Copy link
Owner

Closes #1915.

@nlohmann nlohmann merged commit 4396a68 into nlohmann:develop Apr 11, 2020
@nlohmann
Copy link
Owner

Thanks!

@nlohmann
Copy link
Owner

🔖 Release item

This issue/PR will be part of the next release of the library. This template helps preparing the release notes.

Type

  • ✨ New Feature
  • 🐛 Bug Fix
  • ⚡️ Improvement
  • 🔨 Further Change
  • 🔥 Deprecated function

Description

@nlohmann nlohmann mentioned this pull request Apr 11, 2020
Closed
@dota17 dota17 deleted the document-fix branch April 14, 2020 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
documentation release item: 🔨 further change
Projects
None yet
Milestone
Release 3.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dota17 @nlohmann