Add missing testcase about NaN in unit-constructor1.cpp #2043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlohmann
reviewed
Apr 16, 2020
test/src/unit-constructor1.cpp
Outdated
|
|
||
| // check round trip of NaN | ||
| json::number_float_t d = j; | ||
| CHECK(d == n); |
There was a problem hiding this comment.
Apparently, comparing NaNs with == does not work, hence all CI builds fail. Please check https://stackoverflow.com/questions/15268864/how-to-compare-two-nan-values-in-c.
There was a problem hiding this comment.
Okay, I'll close this. Thanks for reminding : )
There was a problem hiding this comment.
I did not mean to close this - maybe
CHECK(std::is_nan(d) and std::is_nan(n));would also do the job?
dota17
force-pushed
the
unit-constructor1
branch
from
a8beddb to
bb1843b
Compare
dota17
force-pushed
the
unit-constructor1
branch
from
bb1843b to
c379d02
Compare
nlohmann
requested changes
Apr 20, 2020
|
Thanks! |
🔖 Release itemThis issue/PR will be part of the next release of the library. This template helps preparing the release notes. Type
Description
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Describe your pull request here. Please read the text below the line, and make sure you follow the checklist.]
Pull request checklist
Read the Contribution Guidelines for detailed information.
include/nlohmanndirectory, runmake amalgamateto create the single-header filesingle_include/nlohmann/json.hpp. The whole process is described here.