-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly select "Release" build for Travis #2375
Conversation
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
fca58d0
to
7092890
Compare
The coverage test requires the use of the "Debug" configuration. From the GCC documentation:
|
@karzhenkov Can you please update to the latest develop branch? I changed a lot of issues in the CI and moved some checks from Travis to GitHub Actions. Maybe the changes of this PR may need to be applied in |
# Conflicts: # .travis.yml
I think there is nothing here that we can apply to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks! |
Ninja doesn't support multiple build configurations. The option
--config Release
has no effect whencmake --build
is called. Essentially, all testing was performed for "Debug" configuration, which is the default. Maybe it doesn't really matter, but it's misleading. The proper way to select build configuration here is throughCMAKE_BUILD_TYPE
.