-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
readme: fix tilde character display #2582
Conversation
I'm not a maintainer, but here is my IMO. This PR should be divided into "readme: harmonize versions" and "readme: fix While ~ display fix is a really useful fix, version harmonization is discussible. Nobody wants to maintain this manual version harmonization, so version numbers in readme will be outdated immediately after another release. I think, that all such mentions should be universal one like |
I have no idea, but the fact, that version numbers in readme are outdated, means that there is either no such automatization step, or it is not executed for a very long time. So maybe it's time to invent one and integrate into the release process. |
Good idea. I'll do some research and report back. |
It's a terrible idea. Because at least readme contains a lot of version numbers of another software. For e.g. clang
There is even a full match with the current release version. So all the versions of all the mentioned software would become "the same release" as nlohmann/json. Like a rolling snowball. |
That wouldn't be good, but then, how does he do it currently? 🤔 |
Version numbers are updated in a script I run when I prepare a release. The version numbers of the README file are usually not part of it. The versions for the package managers are just examples - I am not a maintainer for those and I'm not willing to check regularly which version is available where. So I concur with #2582 (comment) and would like to see a PR handling the tildes, but rather not touch the version numbers in the README file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not adjust the version numbers, see #2582 (comment).
~
char display~
char display
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks! |
~
character in GitHub in compiler table (it used to look like this: ...1exp1... instead of ...1~exp~1...)