-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibility to use without the dependency to file io and streams to use in intel sgx enclaves #2729
Conversation
includes some macros to be defined for using without file io.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run make amalgamate
to make sure the single header is properly generated. The CI currently fails because this.
Sorry for the inactivity. I have one question left: you write in #2728 that the headers for I/O do not exist. But in your change you seem not to exclude any headers if |
Ah that is true! for example in Should I remove the includes so that it also usable for other applications? |
Yes, please. The use case may be still quite special, but at lease it would not assume include included headers are empty. I could imagine that that flag may be usable for some if they want to reduce compile times if they do not use I/O in their project. |
Does the build pipeline fail because of me or is this an error in the pipeline? |
This seems to be an issue in the pipeline. I need to investigate. |
Please update the branch - I just merged #2817 to fix the CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thank you very much for your support and your review! |
Thanks! |
includes some macros to be defined for using without file io.