Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert invalid fix #3082

Merged
merged 2 commits into from
Oct 16, 2021
Merged

Revert invalid fix #3082

merged 2 commits into from
Oct 16, 2021

Conversation

nlohmann
Copy link
Owner

This PR reverts a fix made with #2561 that incorrectly treats the return values of std::find and std::remove as pointers.

Fixes #3081.

@nlohmann nlohmann added this to the Release 3.10.4 milestone Oct 16, 2021
@nlohmann nlohmann self-assigned this Oct 16, 2021
@nlohmann nlohmann mentioned this pull request Oct 16, 2021
Closed
3 tasks
@nlohmann nlohmann added the review needed It would be great if someone could review the proposed changes. label Oct 16, 2021
@coveralls
Copy link

coveralls commented Oct 16, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 504d0a5 on issue3081 into ba046e4 on develop.

@nlohmann nlohmann merged commit 80cf9d7 into develop Oct 16, 2021
@nlohmann nlohmann deleted the issue3081 branch October 16, 2021 11:27
@nlohmann nlohmann removed the review needed It would be great if someone could review the proposed changes. label Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nlohmann nlohmann

Labels
release item: 🐛 bug fix
Projects
None yet
Milestone
Release 3.10.4
Development

Successfully merging this pull request may close these issues.

Compiler error in output serializer due to 'incompatible initializer'
2 participants
@nlohmann @coveralls