Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable regression test for #3070 on GCC <8.4 #3451

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Disable regression test for #3070 on GCC <8.4 #3451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/src/unit-regression2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ using ordered_json = nlohmann::ordered_json;
#endif

#if JSON_HAS_EXPERIMENTAL_FILESYSTEM
// JSON_HAS_CPP_17 (magic keyword; do not remove)
nlohmann marked this conversation as resolved.
Show resolved Hide resolved
#include <experimental/filesystem>
namespace nlohmann::detail
{
Expand All @@ -61,7 +62,6 @@ namespace std_fs = std::filesystem;
} // namespace nlohmann::detail
#endif


#ifdef JSON_HAS_CPP_20
#include <span>
#endif
Expand Down Expand Up @@ -793,8 +793,8 @@ TEST_CASE("regression tests 2")
const auto j_path = j.get<nlohmann::detail::std_fs::path>();
CHECK(j_path == text_path);

#ifndef _MSC_VER
// works everywhere but on MSVC
#if !defined(_MSC_VER) && !(defined(__GNUC__) && __GNUC__ == 8 && __GNUC_MINOR__ < 4)
// works everywhere but on MSVC and GCC <8.4
nlohmann marked this conversation as resolved.
Show resolved Hide resolved
CHECK_THROWS_WITH_AS(nlohmann::detail::std_fs::path(json(1)), "[json.exception.type_error.302] type must be string, but is number", json::type_error);
#endif
}
Expand Down