fixed duplicate symbols errors on header-only version. issue #16 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the request. This solves the problem for now, but unfortunately the file is generated from the header I am currently working on a header-only file myself - this time, not as a byproduct of a .h/.cc pair of files. I hope to have it released in the weekend. Thanks for your effort anyway! |
GerHobbelt
pushed a commit
to GerHobbelt/nlohmann-json
that referenced
this pull request
May 7, 2021
Sync Fork from Upstream Repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got duplicate symbols errors when include header-only version in more than one cpp files.
So I just add inline keyword before method defines to fix this. Link errors disappeared. Is this enough to close #16?