Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent ndarray size vector from recursive use, fix nlohmann/json#3503 #3505

Merged
merged 5 commits into from
May 23, 2022

Conversation

fangq
Copy link
Contributor

@fangq fangq commented May 22, 2022

It seems that the broken ND array objects in #3503 were results of embedding arrays inside an ND-array size. In #3500, I added a flag to prevent recursive embedding but missed the get_ubjson_size_type function. now this is added. The test data throw errors as expected.

let me know if the fuzzer test still find something else after this patch.

@fangq fangq requested a review from nlohmann as a code owner May 22, 2022 04:37
@coveralls
Copy link

coveralls commented May 22, 2022

Coverage Status

Coverage remained the same at 100.0% when pulling 32a5558 on NeuroJSON:issue3503 into 41226d0 on nlohmann:develop.

@nlohmann
Copy link
Owner

I'll check.

@nlohmann
Copy link
Owner

No problems found so far.

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann linked an issue May 22, 2022 that may be closed by this pull request
@nlohmann nlohmann self-assigned this May 22, 2022
@nlohmann nlohmann added this to the Release 3.11.0 milestone May 22, 2022
@nlohmann
Copy link
Owner

Thanks a lot! I will merge this once AppVeyor is done.

@nlohmann nlohmann merged commit ede6667 into nlohmann:develop May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binary reader for BJData creates incorrect SAX events
3 participants