-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new CI image #3528
Use new CI image #3528
Conversation
nlohmann
commented
Jun 10, 2022
- use CI image 2.4.0
- add new flags for GCC 13
@falbrechtskirchinger PTAL - 32 bit support is now also enabled. |
Welp. I hoped you'd merge one of my 32bit PRs into this one first before I'd do a final review. The addition of |
Oh, sorry. But |
Oh, good. I just quickly glanced at it and misinterpreted the plus sign from the diff. I'll see if there's anything else. |
I wished Clang-Tidy was more flexible and one could define a list of sources that you care about and treat warnings outside these files as out of scope. If I had a stupid Boolean tautology checked in "my" code, I would act on it. But not if it's the consequence of piling up calls from different libraries... |
Agreed. Everything else looks mostly good. The |