Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing <numeric> include #3719

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Add missing <numeric> include #3719

merged 2 commits into from
Aug 30, 2022

Conversation

falbrechtskirchinger
Copy link
Contributor

@falbrechtskirchinger falbrechtskirchinger commented Aug 30, 2022 •
edited
Loading

Include header <numeric> for std::accumulate when JSON_DIAGNOSTICS is enabled.

Fixes #3717.
Closes #3718.

@github-actions github-actions bot added the S label Aug 30, 2022
@falbrechtskirchinger falbrechtskirchinger mentioned this pull request Aug 30, 2022
Closed
2 tasks
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling af54422 on falbrechtskirchinger:missing-include into bed648c on nlohmann:develop.

nlohmann
nlohmann approved these changes Aug 30, 2022
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.11.3 milestone Aug 30, 2022
@nlohmann nlohmann merged commit 307c053 into nlohmann:develop Aug 30, 2022
@falbrechtskirchinger falbrechtskirchinger deleted the missing-include branch August 30, 2022 18:58
@nlohmann nlohmann mentioned this pull request Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees
No one assigned
Labels
S
Projects
None yet
Milestone
Release 3.11.3
Development

Successfully merging this pull request may close these issues.

Compilation error with JSON_DIAGNOSTICS enabled
3 participants
@falbrechtskirchinger @coveralls @nlohmann