Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing files to release artifacts #3728

Merged
merged 2 commits into from
Sep 25, 2022
Merged

Add missing files to release artifacts #3728

merged 2 commits into from
Sep 25, 2022

Conversation

falbrechtskirchinger
Copy link
Contributor

@falbrechtskirchinger falbrechtskirchinger commented Sep 7, 2022 •
edited
Loading

Add missing files to include.zip:

  • amalgamated json_fwd.hpp
  • Bazel build files

Fixes #3727.

@github-actions github-actions bot added the S label Sep 7, 2022
@falbrechtskirchinger
Copy link
Contributor Author

falbrechtskirchinger commented Sep 7, 2022 •
edited
Loading 

$ make include.zip
(...)
  adding: single_include/nlohmann/json_fwd.hpp (deflated 74%)
  adding: BUILD.bazel (deflated 81%)
  adding: WORKSPACE.bazel (stored 0%)

@falbrechtskirchinger falbrechtskirchinger marked this pull request as draft September 7, 2022 07:22
@falbrechtskirchinger
Copy link
Contributor Author

(Let's wait on #3709.)

@coveralls
Copy link

coveralls commented Sep 7, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 2b3a1d4 on falbrechtskirchinger:add-missing-release-files into f4658de on nlohmann:develop.

@falbrechtskirchinger falbrechtskirchinger marked this pull request as ready for review September 20, 2022 06:52
@nlohmann nlohmann added this to the Release 3.11.3 milestone Sep 25, 2022
nlohmann
nlohmann approved these changes Sep 25, 2022
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann merged commit 17d9eac into nlohmann:develop Sep 25, 2022
@nlohmann
Copy link
Owner

Thanks!

@falbrechtskirchinger falbrechtskirchinger deleted the add-missing-release-files branch September 25, 2022 11:55
@nlohmann nlohmann mentioned this pull request Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmarr gregmarr gregmarr approved these changes

@nlohmann nlohmann nlohmann approved these changes

Assignees
No one assigned
Labels
S
Projects
None yet
Milestone
Release 3.11.3
Development

Successfully merging this pull request may close these issues.

Amalgated json_fwd.hpp not included in include.zip
4 participants
@falbrechtskirchinger @coveralls @nlohmann @gregmarr