Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'declaration hides global declaration' warning #3751

Merged

Conversation

falbrechtskirchinger
Copy link
Contributor

@falbrechtskirchinger falbrechtskirchinger commented Sep 17, 2022

The global declaration of j in unit-noexcept.cpp can be hidden by parameters named j. Various PRs have triggered this issue in the past.

Replace json *j = nullptr; with std::declval<json&>().

@coveralls
Copy link

coveralls commented Sep 17, 2022

Coverage Status

Coverage remained the same at 100.0% when pulling e2d15d7 on falbrechtskirchinger:fix-hidden-global-declaration into 9dfa722 on nlohmann:develop.

@github-actions
Copy link

🔴 Amalgamation check failed! 🔴

The source code has not been amalgamated.

@falbrechtskirchinger falbrechtskirchinger force-pushed the fix-hidden-global-declaration branch 2 times, most recently from acc2818 to 513750e Compare September 17, 2022 11:58
@nlohmann nlohmann added this to the Release 3.11.3 milestone Sep 19, 2022
@nlohmann nlohmann merged commit f4658de into nlohmann:develop Sep 19, 2022
@nlohmann
Copy link
Owner

Thanks!

@falbrechtskirchinger falbrechtskirchinger deleted the fix-hidden-global-declaration branch September 19, 2022 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants